refactor: remove implicit Enabled attribute #1898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove the behaviour were an `Enabled` attribute was added by default to composite objects - remove use of the `InihibitEnabled` attribute to suppress the default behaviour - add explicit `Enabled` attributes where they are currently expected by code - extend the `isPresent` macro to throw an error if it doesn't find an `Enabled` attribute isPresent - restrict the specification of attributes for composite object to use the full object based notation, removing the support for string based attributes.
Add `Enabled` attributes required to run the Azure test suite. Also correct the README in regards to running the unit tests.
roleyfoley
approved these changes
Dec 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent of Change
Description
Enabledattribute was added by default to composite objectsInihibitEnabledattribute to suppress the default behaviourEnabledattributes where they are currently expected by codeisPresentmacro to throw an error if it doesn't find anEnabledattributeMotivation and Context
Part of #1894
How Has This Been Tested?
Local template generation
Related Changes
Prerequisite PRs:
Dependent PRs:
Consumer Actions: